[PATCH] D69338: [clangd] Collect name references in the index.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 23 06:05:37 PDT 2019


kadircet accepted this revision.
kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:268
-  // decide to implement renaming with index support.
-  if ((Roles & static_cast<unsigned>(index::SymbolRole::NameReference)))
-    return true;
----------------
This also implies that find refs on a class type will also report locations for constructors and destructors. I believe that's the behavior we decided to have in our offline discussions, just statin in here for future reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69338/new/

https://reviews.llvm.org/D69338





More information about the cfe-commits mailing list