[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

Wed Oct 23 03:22:23 PDT 2019

sammccall added a comment.

In D69328#1718549 <https://reviews.llvm.org/D69328#1718549>, @kadircet wrote:

> In D69328#1718509 <https://reviews.llvm.org/D69328#1718509>, @sammccall wrote:
>
> > Oops, this doesn't actually work - you're not setting the cloned context anywhere...
>
>
> I am moving it into the lambda, which should extend the lifespan of context until destruction of it. Why would I need to set it in addition to that?

Because we don't just want the context to be alive, it should be the context associated with the current thread.
e.g. if a new span is created, it should be nested within the other context.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69328/new/

https://reviews.llvm.org/D69328