[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Not sure 60 is enough, e.g. building a preamble can often take more than a minute and the users will see clangd crashing for (seemingly) no reason on shutdown.
In the long run, we should probably attempt to cancel long-running operations within a much shorter timeframe and a timeout of a minute would make more sense, though.



================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:689
+  std::thread([] {
+    std::this_thread::sleep_for(std::chrono::seconds(6));
+    std::abort();
----------------
Did you mean 60 seconds?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69329/new/

https://reviews.llvm.org/D69329