[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

Tue Oct 22 15:45:05 PDT 2019

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Good find! The following drivers (at least) appear to have the same problem:

  clang/lib/Driver/ToolChains/WebAssembly.cpp:236
  clang/lib/Driver/ToolChains/Solaris.cpp:247
  clang/lib/Driver/ToolChains/Linux.cpp:677
  clang/lib/Driver/ToolChains/Hurd.cpp:148
  clang/lib/Driver/ToolChains/Fuchsia.cpp:289
  clang/lib/Driver/ToolChains/Darwin.cpp:1862

This makes me wonder whether `C_INCLUDE_DIRS` is useful at all. Does anybody use it? Also, if we keep `C_INCLUDE_DIRS`, it would be nice to add a test for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69221/new/

https://reviews.llvm.org/D69221