[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Just a few NITs from my side. I'll let the other review the actual implementation



================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:217
+  void SourceRangeSkipped(SourceRange Range, SourceLocation EndifLoc) override {
+    SkippedRanges.push_back(Range);
+  }
----------------
Maybe keep only ranges from the main file?


================
Comment at: clang-tools-extra/clangd/ParsedAST.h:100
 
+  const std::vector<SourceRange> &getSkippedRanges() const {
+    return SkippedRanges;
----------------
NIT: please return `llvm::ArrayRef<SourceRange>` instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536