[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 22 09:54:47 PDT 2019


hfinkel added a comment.

> I don't see how such warning can help a user. A note about impact of the pragma on performance can be put into documentation. Issuing a warning on every use of the pragma may be annoying.

I definitely agree. Performance may be fine in many cases, and performance may not be *relatively* important where the pragma is used. I don't believe that a warning should be added for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69272/new/

https://reviews.llvm.org/D69272





More information about the cfe-commits mailing list