[PATCH] D54214: [RISCV] Set triple based on -march flag

Tue Oct 22 09:09:27 PDT 2019

jrtc27 added a comment.

In D54214#1718043 <https://reviews.llvm.org/D54214#1718043>, @simoncook wrote:

> Ping, before I rebased this did anyone have any other thoughts on flag precedence?

The precedence seems sensible; it's what MIPS is doing for -mabi vs -target just above.

================
Comment at: clang/lib/Driver/Driver.cpp:541
+  // If target is RISC-V adjust the target triple according to
+  // provided architecture name
+  A = Args.getLastArg(options::OPT_march_EQ);
----------------
Missing a full-stop here

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54214/new/

https://reviews.llvm.org/D54214