[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D69241#1716787 <https://reviews.llvm.org/D69241#1716787>, @ilya-biryukov wrote:

> NIT: there's a typo in the revision title: should be **constructor**, not **consturctor**


Done.



================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:844
+                int $1^abc;
+                $2^X(): $3^abc() {}
+              };
----------------
ilya-biryukov wrote:
> Could you also add a test with the initializer containing a base class? It produces a different kind of `CXXConstructorInitializer`
Done.

While adding more tests, I discover some issues in the implementation, also fixed them in this patch, please review the patch again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69241/new/

https://reviews.llvm.org/D69241