[PATCH] D69186: Refactor DependencyScanningTool to its own file
Michael Spencer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 21 17:39:00 PDT 2019
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
LGTM with style nit. I like that this decouples `DependencyScanningTool` from printing the results.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:105-107
+ llvm::Expected<std::string> &MaybeFile,
+ SharedStream &OS,
+ SharedStream &Errs) {
----------------
This looks like it needs to be clang-formatted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69186/new/
https://reviews.llvm.org/D69186
More information about the cfe-commits
mailing list