[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 21 10:36:54 PDT 2019


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lld/ELF/Driver.cpp:357
+
+  // default
+  return GnuStackKind::NoExec;
----------------
MaskRay wrote:
> MaskRay wrote:
> > This is obvious. The comment can be removed.
> Not done. `// default` can be deleted I think.
You didn't give me time to upload updated patch ;-).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56554/new/

https://reviews.llvm.org/D56554





More information about the cfe-commits mailing list