[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 21 09:58:26 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
> That include seemed irrelevant to DataLayout, as
> wee as lots of users of DataLayout.
Typo in commit message (well as...), worth fixing before landing.
lgtm
================
Comment at: llvm/include/llvm/IR/DataLayout.h:615-616
// The implementation of this method is provided inline as it is particularly
// well suited to constant folding when called on a specific Type subclass.
inline TypeSize DataLayout::getTypeSizeInBits(Type *Ty) const {
----------------
I guess this is the main reason for the Type.h include.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69261/new/
https://reviews.llvm.org/D69261
More information about the cfe-commits
mailing list