[PATCH] D69213: Avoid appending the source directory to an absolute path

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 21 09:22:12 PDT 2019


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:541
+    MainFileDir = MainFile->getDir()->getName();
+    if (MainFileDir != "." && !llvm::sys::path::is_absolute(MainFileName)) {
       llvm::SmallString<1024> MainFileDirSS(MainFileDir);
----------------
JDevlieghere wrote:
> Should we check if `MainFileDir` is absolute to, instead of just checking for `.`?
We might want to unconditionally call remove-dots instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69213/new/

https://reviews.llvm.org/D69213





More information about the cfe-commits mailing list