[PATCH] D69165: [clangd] Store Index in Tweak::Selection
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 21 01:56:49 PDT 2019
kadircet marked 3 inline comments as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71
+ // Index to be passed into Tweak::Selection.
+ const SymbolIndex *Index = nullptr;
+
----------------
ilya-biryukov wrote:
> How is this index populated? Each test has to mock it?
that's what we usually do with the indexes in the rest of the testing code.(see code completion tests for an example)
we might decide to have some defaults if there are a substantial amount of tests making use of the same pattern, wdyt?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69165/new/
https://reviews.llvm.org/D69165
More information about the cfe-commits
mailing list