[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:31
+void BadSignalToKillThreadCheck::check(const MatchFinder::MatchResult &Result) {
+  Preprocessor::macro_iterator It = PP->macro_begin();
+  while (It != PP->macro_end() && !SigtermValue.hasValue()) {
----------------
In this case auto is reasonable, because this is iterator.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:121
+
+  Finds function calls when an uncaught signal try to kill a thread and
+  the signal kills the entire process, not just the individual thread. 
----------------
Please synchronize with first statement in documentation.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:123
+  the signal kills the entire process, not just the individual thread. 
+  To learn more about this rule please visit the following page:
+  https://wiki.sei.cmu.edu/confluence/display/c/POS44-C.+Do+not+use+signals+to+terminate+threads
----------------
Please move this statement at the end of documentation.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69181/new/

https://reviews.llvm.org/D69181