[PATCH] D68340: Add AIX toolchain and basic linker functionality
Jason Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 18 07:32:30 PDT 2019
jasonliu added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AIX.h:19
+
+/// aix -- Directly call system default and linker.
+// TODO: Enable direct call to system default assembler.
----------------
remove "and".
================
Comment at: clang/lib/Driver/ToolChains/AIX.h:36
+
+} // end namespace aix.
+
----------------
Sorry, I don't think we need '.' for any of the "end namespace ..." comment.
================
Comment at: clang/lib/Driver/ToolChains/AIX.h:63
+
+#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_AIX_H.
----------------
We don't need '.' here as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68340/new/
https://reviews.llvm.org/D68340
More information about the cfe-commits
mailing list