[PATCH] D69043: [RFC] Adding time-trace to LLD?

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 17 22:56:19 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/Options.td:361
 
+def time_trace: F<"time-trace">, HelpText<"Record time trace">;
+
----------------
aganea wrote:
> Given this option is a candidate for the other LLD drivers, I am wondering if we couldn't have a shared `lld/Common/CommonOpt.td`. @ruiu WDYT?
In many cases command line options are slightly different among drivers. so currently we have a completely separated option file for each driver. It looks like maintaining each file separately makes things much easier, so I wouldn't create a new common file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69043/new/

https://reviews.llvm.org/D69043





More information about the cfe-commits mailing list