[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output
Jan Korous via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 17 11:40:16 PDT 2019
jkorous added a comment.
I think you could've just used `CHECK-DAG` to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too.
https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive
Using `std::set` here sounds reasonable to me but I'd like @arphaman to be aware of this. BTW should we change `std::vector<std::string> Dependencies;` in `DependencyCollector` to `set` too?
Also, I'm wondering why is the behavior different on Windows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69090/new/
https://reviews.llvm.org/D69090
More information about the cfe-commits
mailing list