[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 17 07:30:31 PDT 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:2280
     }
-    EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls));
+    EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls))
+        << File.code();
----------------
ilya-biryukov wrote:
> This looks unrelated. Maybe revert and land separately?
This patch also modifies the `getNonLocalDeclRefs` which is related to the test here. I'd keep the change in this patch as it is minor and NFC. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68977/new/

https://reviews.llvm.org/D68977





More information about the cfe-commits mailing list