[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:850
+           "1: targets = {Foo::Foo}, decl\n"
+           "2: targets = {Foo::~Foo}, decl\n"
+           "3: targets = {Foo}\n"
----------------
ilya-biryukov wrote:
> Could we avoid reporting destructor references for now? I feel they would create more confusion than bring value.
> Mostly worried that they overlap with a reference to the type name and now all client code will probably want to filter out destructor references.
> 
> I believe they're not critical to any of the use-cases we have so far, having a ``// FIXME: decide how to surface destructors when we need them` should be good enough for now
Agree. it is not needed in rename feature as well, we have a typeLoc occurrence in `~[[Foo]]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68977/new/

https://reviews.llvm.org/D68977