[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 17 04:57:42 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:438
                          D->getTargetNameLoc(),
+                         /*IsDecl=*/true,
                          {D->getAliasedNamespace()}};
----------------
This one is a **not** a declaration reference.
We could call `VisitNamedDecl` here to report the actual declaration.

Note that this would require returning two results from this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68977/new/

https://reviews.llvm.org/D68977





More information about the cfe-commits mailing list