[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 16 15:26:40 PDT 2019


rjmccall added a comment.

I agree with Richard's suggestion of just numbering all the lambdas in both modes if that's viable.



================
Comment at: clang/include/clang/AST/DeclCXX.h:587-590
+    unsigned NumExplicitCaptures : 12;
+
+    /// Has known `internal` linkage.
+    unsigned HasKnownInternalLinkage : 1;
----------------
hliao wrote:
> Try to avoid inflating memory footprint by borrowing one bit from `NumExplicitCaptures`. It seems to me that we won't have that large number (8192) of *explicit* capture.
If this field is necessary, please borrow its space from `ManglingNumber` below rather than the number of explicit captures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68818/new/

https://reviews.llvm.org/D68818





More information about the cfe-commits mailing list