[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

In D68914#1710407 <https://reviews.llvm.org/D68914#1710407>, @owenpan wrote:

> I did a quick search of the LLVM code base and found dozens of `const StringRef &`, including the `Twine` API <https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/ADT/Twine.h#L524>.


`Twine` is "special", don't be influenced by that.  Most of the others are probably mistakes.  It's idiomatic to pass `StringRef` by value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68914/new/

https://reviews.llvm.org/D68914