[PATCH] D68978: [clangd] Propagate main context into ClangdServer

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 15 06:58:36 PDT 2019


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:463
+  // Server, CDB, etc.
+  llvm::Optional<WithContext> MainContext;
+  MainContext.emplace(BackgroundContext.clone());
----------------
As discussed offline: I think it'd be clearer to put this in a small block around the construction of clangd server. (Then we can avoid some ofthe Optional bits too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68978/new/

https://reviews.llvm.org/D68978





More information about the cfe-commits mailing list