[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 15 02:03:50 PDT 2019


klimek added a comment.

In D68914#1709002 <https://reviews.llvm.org/D68914#1709002>, @owenpan wrote:

> Here are some `const StringRef &` examples <https://github.com/llvm/llvm-project/blob/master/clang/lib/StaticAnalyzer/Checkers/IteratorChecker.cpp#L229>.


StringRef already is a const pointer type, so the idiomatic way is to pass it by value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68914/new/

https://reviews.llvm.org/D68914





More information about the cfe-commits mailing list