[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 15 00:36:47 PDT 2019
owenpan added inline comments.
================
Comment at: clang/include/clang/Basic/SourceManager.h:232
+ // nullptr
+ static const char *getInvalidBOM(StringRef BufStr);
};
----------------
klimek wrote:
> owenpan wrote:
> > Can you make the parameter `const`?
> StringRef is inherently const though, right? I think the added const is confusing.
Oops! I meant `const StringRef &`:
```
static const char *getInvalidBOM(const StringRef &BufStr);
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68914/new/
https://reviews.llvm.org/D68914
More information about the cfe-commits
mailing list