[PATCH] D41284: [Concepts] Associated constraints infrastructure.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 14 15:46:39 PDT 2019


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Sema/Sema.h:5950
+  /// associated constraints of an older declaration of which it is a
+  /// redeclaration
+  bool CheckRedeclarationConstraintMatch(TemplateParameterList *Old,
----------------
Missing period.


================
Comment at: clang/test/CXX/concepts-ts/temp/concept/p4.cpp:1
+// RUN:  %clang_cc1 -std=c++2a -fconcepts-ts -verify %s
+
----------------
Please move this test and the others to the relevant place under `test/CXX/temp` rather than `test/CXX/concepts-ts` and remove `-fconcepts-ts` from the `RUN:` lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41284/new/

https://reviews.llvm.org/D41284





More information about the cfe-commits mailing list