[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added a comment.

Hi Michael, thanks for working on this!



================
Comment at: include/clang/Lex/HeaderSearchOptions.h:206
 
+  /// Weather we should include all things that could impact the module in the
+  /// hash.
----------------
*whether


================
Comment at: include/clang/Lex/HeaderSearchOptions.h:209
+  ///
+  /// This includes things like the full header search path.
+  unsigned ModulesStrictHash : 1;
----------------
What else do you plan to add in the future as part of "all the things that could impact"? It seems to me that by default this should always be the case, but header search related things are special because one might want to  handwave on correctness to have smaller caches (default behavior right now). 

I wonder if we should instead have `fmodules-strict-header-seach` and later on add a more generic thing that group such cases? WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68528/new/

https://reviews.llvm.org/D68528