[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 14 01:51:06 PDT 2019


klimek added inline comments.


================
Comment at: clang/include/clang/Basic/SourceManager.h:232
+    // nullptr
+    static const char *getInvalidBOM(StringRef BufStr);
   };
----------------
owenpan wrote:
> Can you make the parameter `const`?
StringRef is inherently const though, right? I think the added const is confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68914/new/

https://reviews.llvm.org/D68914





More information about the cfe-commits mailing list