[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

Mon Oct 14 01:51:05 PDT 2019

klimek added a comment.

In D68554#1707540 <https://reviews.llvm.org/D68554#1707540>, @thakis wrote:

> >   Could you or anyone else point me to a good example, I'd definitely like to take a look.
>
> http://llvm-cs.pcc.me.uk/include/llvm/Support/SourceMgr.h/rSMDiagnostic --
>
> >   `via clang-format?` did you mean via clang.exe or clang-check.exe?   I did think of this when I started doing this work, I just came to the conclusion that if I did that it wouldn't be long before someone requested the same features in clang-format itself.
>
> Err, via clang-tidy. Sorry, that was a super confusing typo. That seems like a great place for this feature to me.

clang-tidy is a compiler tool that needs the full compile info, while clang-format is just a parser; I think it'd be actively confusing to have clang-tidy be a clang-format frontend given how different there usage is.

That said, I agree it's worth looking into using LLVM Diags without all of Clang's overhead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68554/new/

https://reviews.llvm.org/D68554