[PATCH] D66564: [clang-tidy] new performance struct pack align check

[Frank Derry Wanye via Phabricator via cfe-commits]

ffrankies added a comment.

As per the previous discussion, the check has been moved into the `performance` module.

In D66564#1670640 <https://reviews.llvm.org/D66564#1670640>, @lebedev.ri wrote:

> I, too, don't believe this is FPGA specific; it should likely go into `misc-` or even `performance-`.
>  The wording of the diags seems weird to me, it would be good to 1. add more explanation to the docs and 2. reword the diags.


Implemented the requested code refactoring changes, and reworded the diags to now say `accessing the fields in struct 'name' is inefficient due to padding/poor alignment;`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564