[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

[Alex Brachet via Phabricator via cfe-commits]

abrachet added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:469
     // Find llvm-objcopy in order to create the bundle binary.
     ErrorOr<std::string> Objcopy = sys::findProgramByName(
         "llvm-objcopy", sys::path::parent_path(BundlerExecutable));
----------------
I'd be fine removing this FWIW. Is there a high chance they will be in the same directory? I think on a mac, there is very little chance this will be true because Apple preinstalls clang in /usr/bin, but not llvm-objcopy that would have to go in /usr/local/bin. Is it enough of an optimization to keep? Up to you I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68931/new/

https://reviews.llvm.org/D68931