[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 13 10:37:52 PDT 2019


mgorny added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467
+    ErrorOr<std::string> Objcopy = sys::findProgramByName(
+        "llvm-objcopy", sys::path::parent_path(BundlerExecutable));
+    if (!Objcopy) {
----------------
This is broken for running tests in clang standalone builds. `llvm-copy` is installed in the system, unlike `clang-offload-bundler` that is present in build directory. Not to mention it's simply wrong to assume both executables must be in the same directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66485/new/

https://reviews.llvm.org/D66485





More information about the cfe-commits mailing list