[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

[MyDeveloper Day via cfe-commits]

Thank you for handling that

I will look into your suggestions

MyDeveloperDay

On Sat, 12 Oct 2019 at 23:55, Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> This fails on macOS:
>
>   : 'RUN: at line 2';   grep -E "*code should be clang-formatted*"
> /Users/thakis/src/llvm-project/out/gn/obj/clang/test/Format/Output/dry-run.cpp.tmp.stderr
>   --
>   Exit Code: 2
>
>   Command Output (stderr):
>   --
>   grep: repetition-operator operand invalid
>
> grep -E means extended regex, where you want `.*` to match anything. But
> this probably should use FileCheck, or maybe even -verify since you're
> adding a dep on Frontend anyways.
>
> I've reverted this for now to green up the bots.
>
> For the reland, did y'all consider the impact of this on clang-format
> build time (it now depends on Frontend and hence on Driver and Sema, and
> Sema is slow to build) and binary size (it's now basically impossible to
> ever get the diagnostics tables in clang-format gc'd by the linker)?
>
> It might make sense to instead use LLVM's diag stuff (instead of clang's)
> since all the actual diags will be disjoint.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D68554/new/
>
> https://reviews.llvm.org/D68554
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191012/224ef7fb/attachment-0001.html>