[PATCH] D64874: [Sema] Improve handling of function pointer conversions

[Mark de Wever via Phabricator via cfe-commits]

Mordante updated this revision to Diff 224753.
Mordante added a comment.

Removed the language version test.

I also added `clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp` to show this is not enough to allow `noreturn` to all language versions, so this file should not be committed.

Do you want me to look at a way to allow the `noreturn` for C++98/C++11? If yes I prefer to make that a separate commit.

AFAIK the `[[noreturn]]` conversion is a clang extension, should I file a DR for the standard? AFAIK there isn't one yet.

If you still like the patch could you commit it (except `clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp`) since I don't have commit access?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64874/new/

https://reviews.llvm.org/D64874

Files:
  clang/lib/Sema/SemaTemplate.cpp
  clang/test/CXX/conv/conv.fctptr/template-noexcept.cpp
  clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64874.224753.patch
Type: text/x-patch
Size: 3833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191012/9a5d2826/attachment.bin>