[PATCH] D67723: [CodeView] Add option to disable inline line tables.

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1427
+        // Remove debug info intrinsics.
+        if (auto *DbgInst = dyn_cast<DbgDeclareInst>(BI)) {
+          BI = --(DbgInst->eraseFromParent());
----------------
Each of these inherit from DbgVariableIntrinsic, so you should be able to dyn_cast to that, and handle them all with one if.


================
Comment at: llvm/test/Transforms/Inline/no-inline-line-tables.ll:31
+; CHECK-NOT: @f
+; CHECK-NOT: @llvm.dbg.declare
+; CHECK: %{{[0-9]+}} = load i32, i32* %i.addr.i, align 4, !dbg ![[VAR:[0-9]+]]
----------------
Test looks good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67723/new/

https://reviews.llvm.org/D67723