[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 11 10:14:55 PDT 2019


ymandel added a comment.

In D68876#1706131 <https://reviews.llvm.org/D68876#1706131>, @gribozavr wrote:

> WDYT about `clang::transformer`? I don't see much point in the intermediate namespace. However, LGTM either way.


Thanks for the review. I prefer `clang::transformer` but wasn't sure about ettiquete of introducing new namespaces under `clang`. If that's ok, then I'm happy to update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68876/new/

https://reviews.llvm.org/D68876





More information about the cfe-commits mailing list