[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 11 02:54:07 PDT 2019


klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.

lg



================
Comment at: clang/tools/clang-format/ClangFormat.cpp:293
 
+// Returns an invalid BOM
+static const char *hasInValidBOM(StringRef BufStr) {
----------------
I'd name this getInvalidBOM and make the comment
// If BufStr has an invalid BOM, returns the BOM name; otherwise, returns nullptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68554/new/

https://reviews.llvm.org/D68554





More information about the cfe-commits mailing list