[PATCH] D68720: Support -fstack-clash-protection for x86

[Tom Stellard via Phabricator via cfe-commits]

tstellar added inline comments.


================
Comment at: clang/test/CodeGen/stack-clash-protection.c:3
+// RUN: %clang -target x86_64 -o %t.out %s -fstack-clash-protection && %t.out
+
+#include <alloca.h>
----------------
There were concerns[1] raised recently about adding clang tests that were codegen dependent.  Is something being tested here that can't be tested with an IR test?  If you only need to test that the frontend option work, I think checking the IR for the necessary function attributes might be enough.



[1] http://lists.llvm.org/pipermail/cfe-dev/2019-September/063309.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68720/new/

https://reviews.llvm.org/D68720