[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 10 15:12:27 PDT 2019
ABataev added inline comments.
================
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+ switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+ case 4u:
----------------
sdmitriev wrote:
> ABataev wrote:
> > Same question as before: maybe better to make the size of size_t type a parameter of a tool?
> As I remember you also had another suggestion - change size_t to intptr_t. That will eliminate the need to an additional parameter for size type. Will it be better?
In thi case we'll need to change the type in the libomptarget.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68746/new/
https://reviews.llvm.org/D68746
More information about the cfe-commits
mailing list