[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 10 14:24:33 PDT 2019


hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: clang/lib/Tooling/Tooling.cpp:102
+      if (isa<driver::OffloadAction>(A)) {
+        assert(Actions.size() == 2);
+        assert(isa<driver::CompileJobAction>(Actions.front()));
----------------
tra wrote:
> Why 2? Will it not be different if user targeted multiple GPUs?
> 
that's the number of top-level actions. no matter how many GPUs are specified, that offload action is the top-level action masters all of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68660/new/

https://reviews.llvm.org/D68660





More information about the cfe-commits mailing list