[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

Wed Oct 9 20:31:24 PDT 2019

ymandel marked 2 inline comments as done.
ymandel added inline comments.

================
Comment at: clang/lib/Tooling/Transformer/CMakeLists.txt:3
+
+add_clang_library(clangTransformer
+  RangeSelector.cpp
----------------
thakis wrote:
> All the other libs in lib/Tooling/Foo are called clangToolingFoo, not clangFoo. Can you please rename this library to clangToolingTransformer?
Not all:
https://reviews.llvm.org/source/llvm-github/browse/master/clang/lib/Tooling/DependencyScanning/CMakeLists.txt

I checked this before. :) Is there a reason that you want that naming scheme or just for consistency? I think that clangTransformer is a better name for the library, but I don't care much. I just noticed we didn't seem to be consistent anyhow, so went w/ my (slight) preference.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68637/new/

https://reviews.llvm.org/D68637