[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 16:40:16 PDT 2019


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm!

In PR43614 I mentioned adding an extra argument to llvm-cov to specify the base directory. On second thought, the existing `-path-equivalence` option should make that unnecessary.



================
Comment at: clang/test/CoverageMapping/debug-dir.cpp:14
+//
+// RELATIVE: @__llvm_coverage_mapping = {{.*"\\01[^/]*foobar.*debug-dir\.cpp}}
+
----------------
Does the "[^/]" check work on Windows, or is something like "[^/\\]" necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68733/new/

https://reviews.llvm.org/D68733





More information about the cfe-commits mailing list