[PATCH] D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: clang/lib/AST/ExprConstant.cpp:5446
        I != E; ++I) {
     if (!Evaluate(ArgValues[I - Args.begin()], Info, *I)) {
       // If we're checking for a potential constant expression, evaluate all
----------------
As an unrelated, optional suggestion, given how common `I-Args.begin()` is, it seems like it would be simpler to do the usual index iteration pattern here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68716/new/

https://reviews.llvm.org/D68716