[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 10:57:00 PDT 2019


rsmith added a comment.

In D68581#1701787 <https://reviews.llvm.org/D68581#1701787>, @aaron.ballman wrote:

> I think this seems like reasonable behavior (for instance, we include the location of a storage class specifier already), but I am curious if @rsmith agrees.


Yes, I do agree. Though please be careful about the case where the first attribute occurs after the first decl-specifier (`int __attribute__((...)) x;`).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68581/new/

https://reviews.llvm.org/D68581





More information about the cfe-commits mailing list