[PATCH] D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl

Mitchell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 09:59:49 PDT 2019


mitchell-stellar added a comment.

To me, whether or not the assertion was valid is irrelevant. That assertion was intentionally added, and its replacement with an `if()` statement materially changes the inputs and outputs of the function. I'm questioning whether the input of a "while" token within a preprocessor statement should output `true` or `false`. (Before, it didn't output anything; it errored.) Does this make sense? I'm just asking for clarification on this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68707/new/

https://reviews.llvm.org/D68707





More information about the cfe-commits mailing list