[PATCH] D68710: Remove time-trace message as it is inconsistent style
Sylvestre Ledru via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 9 09:31:27 PDT 2019
sylvestre.ledru added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:1797
+ HelpText<"Turn on time profiler. Generates JSON file based on output filename. "
+ "Results can be analyzed with chrome://tracing or `Speedscope App "
+ "<https://www.speedscope.app>`_ for flamegraph visualization." >,
----------------
I am not a big fan of adding products in the in-product help.
If Chrome removes the feature or Speedscope goes done, we will still list that in the old version of clang.
Deprecated doc is more common and accepted.
I would remove this line and the next line and keep the doc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68710/new/
https://reviews.llvm.org/D68710
More information about the cfe-commits
mailing list