[PATCH] D68702: [clangd] Make sure ReplyCallbacks are destroyed before RequestCancelersMutex
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 9 06:33:18 PDT 2019
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:429
+ // for cases where LSP clients don't reply for the request.
+ static constexpr int MaxReplayCallbacks = 100;
+ mutable std::mutex CallMutex;
----------------
Please document that this has to go after `RequestCancelersMutex`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68702/new/
https://reviews.llvm.org/D68702
More information about the cfe-commits
mailing list