[PATCH] D68665: [HIP] Fix -save-temps

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Driver/Driver.cpp:4400
+      // HIP image for device compilation with -fno-gpu-rdc is per compilation
+      // unit.
+      bool IsHIPNoRDC = JA.getOffloadingDeviceKind() == Action::OFK_HIP &&
----------------
... so we derive the file name from the main file name.


================
Comment at: lib/Driver/Driver.cpp:4405
+      if (IsHIPNoRDC)
+        Output = BaseName.substr(0, BaseName.rfind('.'));
       Output += OffloadingPrefix;
----------------
`llvm::sys::path::replace_extension(Output, "");` ?


================
Comment at: lib/Driver/ToolChains/HIP.cpp:253
+    constructLlcCommand(C, JA, Inputs, Args, SubArchName, Prefix, OptCommand,
+                        true);
   const char *LlcCommand =
----------------
`/*OutputIsAsm=*/true`


================
Comment at: lib/Driver/ToolChains/HIP.h:62
+                                  const char *InputFileName,
+                                  bool IsAsm = false) const;
 
----------------
`OutputIsAsm`?  Otherwise it's not quite clear what `IsAsm` refers to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68665/new/

https://reviews.llvm.org/D68665