[PATCH] D68340: Add AIX toolchain and basic linker functionality

[Xiangling Liao via Phabricator via cfe-commits]

Xiangling_L added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:38
+
+  if (!Args.hasArg(options::OPT_nostdlib)) {
+    CmdArgs.push_back("-e");
----------------
Test with Clangtana on terran, when no '-nostdlib' specified, since '-e' & '__start' are the default behavior for AIX system linker, so there are no explicitly '-e' & '__start' found on linker input commanline, so I am wondering do we need to explicitly add them to 'CmdArgs'?


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:47
+  else
+    CmdArgs.push_back("-bso");
+
----------------
Ditto. Since by default, AIX linker is dynamically linked, '-bso' is implicitly set on AIX system linker when testing with Clangtana, so do we need to explicitly set '-bso' in LLVM?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68340/new/

https://reviews.llvm.org/D68340