[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 8 12:12:43 PDT 2019


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:7842
+// This implementation is inspired by Sema::mergeDeclAttributes.
+void ASTNodeImporter::CopyInheritedAttributes(FunctionDecl *Old,
+                                              FunctionDecl *New) {
----------------
There are other attributes that [apply to functions as well](https://en.cppreference.com/w/cpp/language/attributes): `nodiscard`, `maybe_unused` and `deprecated`. Is there a reason not to support those as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68634/new/

https://reviews.llvm.org/D68634





More information about the cfe-commits mailing list